Adds content-filtering to the Subscription class#898
Closed
wayneparrott wants to merge 4 commits intoRobotWebTools:developfrom
Closed
Adds content-filtering to the Subscription class#898wayneparrott wants to merge 4 commits intoRobotWebTools:developfrom
wayneparrott wants to merge 4 commits intoRobotWebTools:developfrom
Conversation
makes makes this feature available to rclnodejs developers. node.js - added contentFilter to Options - added static getDefaultOptions() - updated createSubscription() to support contentFilter node.d.ts - added content-filter types rcl_bindings.cpp - added content-filtering to CreateSubscription() rmw.js - new class for identifying the current ROS middleware test-subscription-content-filter.js - test cases for content-filters examples: - publisher-content-filtering-example.js - subscription-content-filtering-example.js package.json - added build/rebuild scripts for convenience
On windows workflow use node 18.12.0 inplace of 18.13.0. There is a repeatable issue with node-gyp configuration on node 18.13. It seems to be related to the node cache. Switching to 18.12 avoids using a cached version of node 18 and the issue no longer occurs. Fix RobotWebTools#890
Contributor
Author
|
I discovered that I omitted an additional api for resetting a subscription content-filter. Please hold off reviewing. I will reopen this PR once I've implemented that feature. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ROS Humble introduced the content-filtering topics feature. This PR
makes makes this feature available to rclnodejs developers.
Resources
DDS 1.4 specification, Annex B
Content-filtering tutorial
ros2/design#282
Supported RMWs
Content-filtering is supported by the following RMWs as of the Humble release:
rmw_cyclonedds_cpp does NOT support content-filtering yet.
Key Changes
node.js
node.d.ts
rcl_bindings.cpp
rmw.js
test-subscription-content-filter.js
examples
package.json